Couple of real quick notes and points to make...
1. Bilstein Sports are not shorter than the stock shocks when they are fully compressed. they are the same.
2. The H&R Cup kit is a pretty well matched setup and is stiffer than the Bilstein/Eibach ProKit setup, though still comfortable enough for a daily driver. I know, I've been in both and I bought the cup kit.
3. A good choice for shocks are Konis (if you can afford them) or Tokicos Illuminas. Both shocks are adjustable for firmness. Stay away from Tokico HPs.
4. H&R Springs are stiffer than the Eibachs. By how much is anyone's guess (unless you work for H&R - they won't divulge their spring rates). Though they will say that the sport springs are 30% stiffer than stock, and the cup kit's are 40% stiffer than stock.
5. All e30's shocks are interchangable except for the 85-85 318i's. The early 318i's had 42mm tube diameters and all other model until the end of e30 production used 51mm. If you have a 318i (M42 engine) you can upgrade to 325i/M3 shocks/struts because of the heavier 6 cyl. engine. However, if you have a 325e/i/M3 do NOT downgrade to 318i shocks.
6. If you lower your car, be prepared for a couple of things...
- Increased camber (look into camber/caster plates for the front and eccentric bushings for the rear)
- Increased tire wear (in case you missed the last point)
- bottoming out on speed bumps and deep potholes and the like (depends on how low you go)
Sorry to be such a post whore. There a lot more than a lot of people realize is involved. There are a lot of choices out there. Bottom line...do your homework before buying something. making a switch later on just eats up your time and money.
If you are going to install, it's a very simple job. I did my entire suspension in about 2 hours. You will need the following tools to do this properly and SAFELY:
Impact gun (air or electric)
MacPhearson strut compressor. Do NOT use a coil spring compressor unless you really know what you're doing.
Assorted sockets (metric of course)
10/12/15/17/19mm wrenches.
Hope this info helps!